SWAMPy

✎ CARVE FLESH

EDITING: move_sub_account_grading_periods_to_courses_spec.rb

# frozen_string_literal: true

#
# Copyright (C) 2016 - present Instructure, Inc.
#
# This file is part of Canvas.
#
# Canvas is free software: you can redistribute it and/or modify it under
# the terms of the GNU Affero General Public License as published by the Free
# Software Foundation, version 3 of the License.
#
# Canvas is distributed in the hope that it will be useful, but WITHOUT ANY
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
# A PARTICULAR PURPOSE. See the GNU Affero General Public License for more
# details.
#
# You should have received a copy of the GNU Affero General Public License along
# with this program. If not, see <http://www.gnu.org/licenses/>.

describe DataFixup::MoveSubAccountGradingPeriodsToCourses do
  let(:group_helper)   { Factories::GradingPeriodGroupHelper.new }
  let(:period_helper)  { Factories::GradingPeriodHelper.new }
  let(:run_data_fixup) { DataFixup::MoveSubAccountGradingPeriodsToCourses.run }

let(:root_account_groups) { GradingPeriodGroup.where(account_id: @root_account.id) }
  let(:root_account_periods) do
    GradingPeriod.where(grading_period_group_id: root_account_groups.select(:id))
  end
  let(:sub_account_groups) { GradingPeriodGroup.where(account_id: @sub_account.id) }
  let(:sub_account_periods) do
    GradingPeriod.where(grading_period_group_id: sub_account_groups.select(:id))
  end
  let(:sub_sub_account_groups) { GradingPeriodGroup.where(account_id: @sub_account_of_sub_account.id) }
  let(:sub_sub_account_periods) do
    GradingPeriod.where(grading_period_group_id: sub_sub_account_groups.select(:id))
  end

let(:legacy_group_for_sub_account) do
    lambda do |sub_account|
      group = sub_account.grading_period_groups.build(group_helper.valid_attributes)
      group.save(validate: false)
      group
    end
  end

before do
    @root_account = Account.create(name: "new account")
    @sub_account = @root_account.sub_accounts.create!
  end

describe "accounts" do
    context "root accounts" do
      before do
        group = group_helper.create_for_account(@root_account)
        period_helper.create_with_weeks_for_group(group, 4, -4)
        run_data_fixup
      end

it "does not delete grading period groups" do
        expect(root_account_groups.active.count).to eq 1
        expect(root_account_groups.count).to eq 1
      end

it "does not delete grading periods" do
        expect(root_account_periods.active.count).to eq 1
        expect(root_account_periods.count).to eq 1
      end
    end

context "sub accounts" do
      before do
        group = legacy_group_for_sub_account.call(@sub_account)
        period_helper.create_with_weeks_for_group(group, 4, -4)
        run_data_fixup
      end

it "soft deletes grading period groups" do
        expect(sub_account_groups.active).to be_empty
        expect(sub_account_groups.count).to eq 1
      end

it "soft deletes grading periods" do
        expect(sub_account_periods.active).to be_empty
        expect(sub_account_periods.count).to eq 1
      end
    end
  end

describe "sub-account courses" do
    before do
      @sub_account_of_sub_account = @sub_account.sub_accounts.create!
      @course = @sub_account_of_sub_account.courses.create!
    end

context "with grading periods" do
      before do
        group = group_helper.legacy_create_for_course(@course)
        period_helper.create_presets_for_group(group, :past, :current, :future)
        @periods_before_fixup = @course.grading_periods.to_a
      end

context "no accounts (root or sub) have grading periods" do
        it "does not have its grading periods altered in any way" do
          run_data_fixup
          @course.reload
          expect(@course.grading_periods).to eq(@periods_before_fixup)
        end
      end

context "root and sub accounts have grading periods" do
        it "does not have its grading periods altered in any way" do
          root_group = group_helper.create_for_account(@root_account)
          sub_group = legacy_group_for_sub_account.call(@sub_account)
          sub_sub_group = legacy_group_for_sub_account.call(@sub_account_of_sub_account)
          period_helper.create_presets_for_group(root_group, :current)
          period_helper.create_presets_for_group(sub_group, :current)
          period_helper.create_presets_for_group(sub_sub_group, :current)
          run_data_fixup
          @course.reload
          expect(@course.grading_periods).to eq(@periods_before_fixup)
        end
      end

context "sub accounts have grading periods, root account does not" do
        it "does not have its grading periods altered in any way" do
          sub_group = legacy_group_for_sub_account.call(@sub_account)
          sub_sub_group = legacy_group_for_sub_account.call(@sub_account_of_sub_account)
          period_helper.create_presets_for_group(sub_group, :current)
          period_helper.create_presets_for_group(sub_sub_group, :current)
          run_data_fixup
          @course.reload
          expect(@course.grading_periods).to eq(@periods_before_fixup)
        end
      end

context "root account has grading periods, sub accounts do not" do
        it "does not have its grading periods altered in any way" do
          group = group_helper.create_for_account(@root_account)
          period_helper.create_presets_for_group(group, :current)
          run_data_fixup
          @course.reload
          expect(@course.grading_periods).to eq(@periods_before_fixup)
        end
      end
    end

context "without grading periods" do
      let(:root_account_periods_attrs) do
        root_account_periods.to_a.map do |period|
          { title: period.title, start_date: period.start_date, end_date: period.end_date }
        end
      end

let(:sub_account_periods_attrs) do
        sub_account_periods.to_a.map do |period|
          { title: period.title, start_date: period.start_date, end_date: period.end_date }
        end
      end

let(:sub_account_of_sub_account_periods_attrs) do
        sub_sub_account_periods.to_a.map do |period|
          { title: period.title, start_date: period.start_date, end_date: period.end_date }
        end
      end

let(:course_periods_attrs) do
        @course.grading_periods.map do |period|
          { title: period.title, start_date: period.start_date, end_date: period.end_date }
        end
      end

context "no accounts (root or sub) have grading periods" do
        it "does not have its (non-existent) grading periods altered in any way" do
          run_data_fixup
          expect(course_periods_attrs).to be_empty
        end
      end

context "root account has grading periods, sub accounts do not" do
        it "does not have its (non-existent) grading periods altered in any way" do
          group = group_helper.create_for_account(@root_account)
          period_helper.create_presets_for_group(group, :current)
          run_data_fixup
          expect(course_periods_attrs).to be_empty
        end
      end

context "root and sub accounts have grading periods" do
        it "receives copies of the 'nearest' sub-account's grading periods" do
          root_group = group_helper.create_for_account(@root_account)
          sub_group = legacy_group_for_sub_account.call(@sub_account)
          sub_sub_group = legacy_group_for_sub_account.call(@sub_account_of_sub_account)
          period_helper.create_presets_for_group(root_group, :current)
          period_helper.create_presets_for_group(sub_group, :current)
          period_helper.create_presets_for_group(sub_sub_group, :current)
          run_data_fixup
          expect(course_periods_attrs).to eq(sub_account_of_sub_account_periods_attrs)
        end
      end

context "sub accounts have grading periods, root account does not" do
        it "receives copies of the 'nearest' sub-account's grading periods" do
          sub_group = legacy_group_for_sub_account.call(@sub_account)
          sub_sub_group = legacy_group_for_sub_account.call(@sub_account_of_sub_account)
          period_helper.create_presets_for_group(sub_group, :current)
          period_helper.create_presets_for_group(sub_sub_group, :current)
          run_data_fixup
          expect(course_periods_attrs).to eq(sub_account_of_sub_account_periods_attrs)
        end
      end

context "nearest sub-account does not have grading periods, next sub-account " \
              "does, and root account does not have grading periods" do
        before do
          sub_group = legacy_group_for_sub_account.call(@sub_account)
          period_helper.create_presets_for_group(sub_group, :current)
          run_data_fixup
        end

it "receives copies of the next 'nearest' sub-account's grading periods" do
          expect(course_periods_attrs).to eq(sub_account_periods_attrs)
        end

it "does not copy the grading_period_group_id over when copying grading periods" do
          grading_period_group_ids = @course.grading_periods.map(&:grading_period_group_id)
          sub_account_grading_period_group_ids = sub_account_periods.pluck(:grading_period_group_id)
          intersection = grading_period_group_ids & sub_account_grading_period_group_ids
          expect(intersection).to be_empty
        end
      end
    end
  end
end

CANCEL

Name	Type	Size	Modified	Actions
↩ ..	DIR	—	—
📁 granular_permissions/	DIR	—	2023-09-24 03:36
📁 lti/	DIR	—	2023-09-24 03:39
📄 add_beta_domain_to_outcomes_service_spec.rb	RB	2.8 KB	2023-09-24 03:36	EDIT
📄 add_external_tool_id_to_quiz_lti_tools_spec.rb	RB	2.7 KB	2023-09-24 03:36	EDIT
📄 add_heap_fields_to_commons_spec.rb	RB	3.8 KB	2023-09-24 03:36	EDIT
📄 add_lti_tool_proxy_id_to_lti_message_handler_spec.rb	RB	1.1 KB	2023-09-24 03:36	EDIT
📄 add_post_policies_to_assignments_spec.rb	RB	6 KB	2023-09-24 03:39	EDIT
📄 add_rcs_app_host_to_quiz_lti_tools_spec.rb	RB	2.6 KB	2023-09-24 03:36	EDIT
📄 add_rcs_service_jwt_to_quiz_lti_tools_spec.rb	RB	2.8 KB	2023-09-24 03:36	EDIT
📄 add_user_uuid_to_learning_outcome_results_spec.rb	RB	1.8 KB	2023-09-24 03:36	EDIT
📄 backfill_attachment_ids_on_media_tracks_spec.rb	RB	3 KB	2023-09-24 03:36	EDIT
📄 backfill_dev_key_account_bindings_for_deleted_keys_spec.rb	RB	2.9 KB	2023-09-24 03:36	EDIT
📄 backfill_dev_key_account_bindings_spec.rb	RB	1.7 KB	2023-09-24 03:36	EDIT
📄 backfill_moderation_graders_spec.rb	RB	2.7 KB	2023-09-24 03:36	EDIT
📄 backfill_new_default_help_link_spec.rb	RB	3.7 KB	2023-09-24 03:36	EDIT
📄 backfill_nulls_spec.rb	RB	1.9 KB	2023-09-24 03:36	EDIT
📄 backfill_posted_at_on_submissions_spec.rb	RB	1.7 KB	2023-09-24 03:36	EDIT
📄 change_immersive_reader_allowed_on_to_on_spec.rb	RB	3.2 KB	2023-09-24 03:36	EDIT
📄 cleanup_cross_shard_developer_keys_spec.rb	RB	4.3 KB	2023-09-24 03:36	EDIT
📄 cleanup_invalid_assignment_group_rules_spec.rb	RB	1.7 KB	2023-09-24 03:36	EDIT
📄 clear_account_settings_spec.rb	RB	2.8 KB	2023-09-24 03:36	EDIT
📄 clear_old_communication_channel_root_account_ids_spec.rb	RB	1.3 KB	2023-09-24 03:36	EDIT
📄 clear_old_user_root_account_ids_spec.rb	RB	1 KB	2023-09-24 03:36	EDIT
📄 create_lti_links_for_legacy_lti_tool_settings_spec.rb	RB	2.1 KB	2023-09-24 03:36	EDIT
📄 create_subscriptions_for_plagiarism_tools_spec.rb	RB	7.9 KB	2023-09-24 03:36	EDIT
📄 delete_extra_placeholder_submissions_spec.rb	RB	1.3 KB	2023-09-24 03:36	EDIT
📄 delete_invalid_communication_channels_spec.rb	RB	2.6 KB	2023-09-24 03:36	EDIT
📄 fix_planner_overrides_marked_complete_spec.rb	RB	1.8 KB	2023-09-24 03:36	EDIT
📄 fix_select_final_grade_for_existing_accounts_spec.rb	RB	8.4 KB	2023-09-24 03:36	EDIT
📄 flag_eportfolios_on_empty_users_spec.rb	RB	1.8 KB	2023-09-24 03:36	EDIT
📄 migrate_homeroom_settings_to_columns_spec.rb	RB	1.5 KB	2023-09-24 03:36	EDIT
📄 move_feature_flags_to_settings_spec.rb	RB	12.1 KB	2023-09-24 03:36	EDIT
📄 move_sub_account_grading_periods_to_courses_spec.rb	RB	9.1 KB	2023-09-24 03:36	EDIT
📄 populate_field_on_model_from_association_spec.rb	RB	1.3 KB	2023-09-24 03:36	EDIT
📄 populate_identity_hash_on_context_external_tools_spec.rb	RB	2.6 KB	2023-09-24 03:36	EDIT
📄 populate_missing_conversation_and_conversation_participant_root_account_ids_spec.rb	RB	4.4 KB	2023-09-24 03:36	EDIT
📄 populate_missing_root_account_ids_if_single_root_account_install_spec.rb	RB	3.9 KB	2023-09-24 03:36	EDIT
📄 populate_root_account_id_for_enrollment_dates_overrides.rb	RB	1.4 KB	2023-09-24 03:39	EDIT
📄 populate_root_account_id_on_attachments_spec.rb	RB	4 KB	2023-09-24 03:36	EDIT
📄 populate_root_account_id_on_calendar_events_spec.rb	RB	4.2 KB	2023-09-24 03:36	EDIT
📄 populate_root_account_id_on_models_spec.rb	RB	46.6 KB	2023-09-24 03:39	EDIT
📄 populate_root_account_ids_for_communication_channels_spec.rb	RB	1.8 KB	2023-09-24 03:36	EDIT
📄 populate_root_account_ids_on_communication_channels_spec.rb	RB	1.4 KB	2023-09-24 03:36	EDIT
📄 populate_root_account_ids_on_conversations_tables_spec.rb	RB	4.4 KB	2023-09-24 03:36	EDIT
📄 populate_root_account_ids_on_learning_outcomes_spec.rb	RB	2.9 KB	2023-09-24 03:36	EDIT
📄 populate_root_account_ids_on_users_spec.rb	RB	2.9 KB	2023-09-24 03:36	EDIT
📄 populate_scores_and_metadata_for_assignment_groups_and_teacher_view_spec.rb	RB	6.1 KB	2023-09-24 03:36	EDIT
📄 populate_submission_anonymous_ids_spec.rb	RB	1.6 KB	2023-09-24 03:36	EDIT
📄 reassociate_grading_period_groups_spec.rb	RB	3.6 KB	2023-09-24 03:36	EDIT
📄 recalculate_section_override_dates_spec.rb	RB	3.9 KB	2023-09-24 03:36	EDIT
📄 reclaim_instfs_attachments_spec.rb	RB	6.7 KB	2023-09-24 03:36	EDIT
📄 remove_delicious_spec.rb	RB	1.8 KB	2023-09-24 03:36	EDIT
📄 remove_invalid_course_pace_module_items_spec.rb	RB	1.9 KB	2023-09-24 03:36	EDIT
📄 remove_invalid_locales_spec.rb	RB	2.2 KB	2023-09-24 03:36	EDIT
📄 resend_plagiarism_events_spec.rb	RB	3.8 KB	2023-09-24 03:39	EDIT
📄 set_account_setting_enable_turnitin_spec.rb	RB	1.6 KB	2023-09-24 03:36	EDIT
📄 set_actl_context_type_for_course_level_tool_proxies_spec.rb	RB	2.5 KB	2023-09-24 03:36	EDIT
📄 set_existing_binding_state_spec.rb	RB	2.2 KB	2023-09-24 03:36	EDIT
📄 set_lti_line_items_coupled_spec.rb	RB	2.7 KB	2023-09-24 03:36	EDIT
📄 set_posting_notification_frequency_spec.rb	RB	10.5 KB	2023-09-24 03:36	EDIT
📄 turn_off_anonymous_grading_for_discussion_topics_and_quizzes_spec.rb	RB	3.8 KB	2023-09-24 03:36	EDIT
📄 update_anonymous_grading_settings_spec.rb	RB	5.4 KB	2023-09-24 03:36	EDIT
📄 update_developer_key_scopes_spec.rb	RB	3.5 KB	2023-09-24 03:36	EDIT
📄 update_grading_standards_to_full_range_spec.rb	RB	3.6 KB	2023-09-24 03:36	EDIT